Skip to content

docs: force space after await in no-floating-promises snippet #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

  • Addresses an existing open issue: No - docs PR.
  • That issue was marked as accepting prs - No - docs PR
  • Steps in Contributing were taken

Overview

This just tweaks the formatting for a code snippet as it appears on the rule site.
Addresses https://github.com/typescript-eslint/typescript-eslint/pull/1799/files#r399829282.
Workaround for prettier/prettier#6608.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 961c989
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/659c61d0e1016d0008921b91
😎 Deploy Preview https://deploy-preview-8228--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense pending the Prettier issue. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8ca5e5e into typescript-eslint:main Jan 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
@kirkwaiblinger kirkwaiblinger deleted the space-after-await branch February 21, 2024 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants