-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [require-await] Allow concise arrow function bodies #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [require-await] Allow concise arrow function bodies #826
Conversation
Thanks for the PR, @scottohara! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
+ Coverage 94.07% 94.07% +<.01%
==========================================
Files 113 113
Lines 4911 4914 +3
Branches 1368 1368
==========================================
+ Hits 4620 4623 +3
Misses 165 165
Partials 126 126
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this
The
@typescript-eslint/require-await
rule exists to allow exceptions to the core ESLintrequire-await
rule for async functions that return a promise (where adding anawait
to the return to suppress therequire-await
warnings would in turn trigger warnings forno-return-await
).The initial implementation of the
@typescript-eslint/require-await
rule allowed the following exceptions:(the rule was only checking
ReturnStatement
nodes)This PR adds support for:
(single-line expressions that don't explicitly include a
return
statement)Prior to this PR, the following code would fall through to the core ESLint
require-await
rule and trigger warnings:After this PR, only the last example should fall through to the core rule and triggers a warning: