-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: add typescript-eslint
package scaffold
#8296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
50df23d
to
23cc699
Compare
You can replace the explicit versions with |
@merceyz oh that's interesting! I didn't know that existed. I had noticed that there was the syntax when I looked at the lock file (you can see I used it in the root package.json) - but I didn't realise that it would automatically get replaced on publish! That's super cool! Cc @JamesHenry - we use the nx packages for publishing - does nx use And for an FYI @JoshuaKGoldberg |
@bradzacher Right now there is a fork in the road when it comes to non semver versions. Either:
OR
This second option is how the Nx repo itself does it. The source of truth for versions in this case is therefore not disk, but rather the npm registry. Nx release supports this case via config in nx.json. BackgroundThis fundamental choice is down to the implementation of Some release tools read your files but then perform all kinds of modifications in memory which are not reflected anywhere on your file system for you to see/play with and then publish that in memory object to npm. This can make troubleshooting bad publishes nearly impossible at times - with this approach it's trivial, because you can always So when you perform your versioning step, Now, having said all that... When we first created this hard line we only had the three subcommands available: These days we have the programmatic API for This is the issue to track for progress: nrwl/nx#20978 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to start, just requesting changes on the license and missing docs. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s finalize the discord discussion before merging
core
package scaffoldtypescript-eslint
package scaffold
5fede03
to
efa076f
Compare
a9ad49e
to
7d3db25
Compare
7d3db25
to
8c99889
Compare
8c99889
to
7c3f8cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update name as per discussion.
PR Checklist
Overview
This PR just adds an private scaffold for the
typescript-eslint
package being added in #7935. I've split this out so that the automation will bump the versions with each release.The most annoying part of the branch is every time I go back to it and rebase it on
main
I have to manually resolve and correct all of the versions or else things will use old releases from npm instead of the repo code.