fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types #8304

tobySolutions · 2024-01-26T14:17:22Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-unsafe-assignment] Differentiate a types-error any from a "true" any #8231
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2024-01-26T14:17:25Z

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-01-26T14:17:27Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`b70a2ca`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/665d2fb149db430008917a53
😎 Deploy Preview	https://deploy-preview-8304--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 8 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg

A great start, thanks again for working on this with me!

Requesting changes mostly around adding in more testing. A couple small refactors too. But the functionality looks great! ✨

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts

packages/type-utils/src/predicates.ts

packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts

nx-cloud · 2024-03-25T22:57:54Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b70a2ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg · 2024-05-26T10:49:42Z

👋 @tobySolutions ping, just checking in - is this something you still have the time and energy for? It's still in draft & there are some CI ❌s so we haven't looked at it.

tobySolutions · 2024-05-26T10:55:23Z

👋 @tobySolutions ping, just checking in - is this something you still have the time and energy for? It's still in draft & there are some CI ❌s so we haven't looked at it.

Definitely Josh! I will resume work on this in a bit. Thank you so very much for checking in! 🙌

…lint into fix/error-type-assignment

yarn.lock

JoshuaKGoldberg

Progress! 🚀

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts

packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts

JoshuaKGoldberg

🙌 Great! Thanks for working with me on this @tobySolutions. I'm excited to see a better error message for no-unsafe-assignment on production soon!

Only one change request left from me, to add a bit more to the tests. It's a pretty small thing - so marking as 1 approval to let someone else from the team chime in if the want.

packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts

tobySolutions · 2024-06-03T02:11:35Z

🙌 Great! Thanks for working with me on this @tobySolutions. I'm excited to see a better error message for no-unsafe-assignment on production soon!

Only one change request left from me, to add a bit more to the tests. It's a pretty small thing - so marking as 1 approval to let someone else from the team chime in if the want.

Yay!!!

Josh-Cena · 2024-06-03T02:15:20Z

If it only changes one rule, then it doesn't fix #8231, only partially

JoshuaKGoldberg · 2024-06-03T02:16:20Z

Yup - I'm about to post an edit splitting the issue up 😄

Josh-Cena · 2024-06-03T02:22:22Z

What about other no-unsafe rules?

JoshuaKGoldberg · 2024-06-03T02:26:46Z

🙌 Filed!

…r test cases

JoshuaKGoldberg

This is wonderful, thanks @tobySolutions!

We've got a bunch of issues filed to apply similar improvements to other no-unsafe-* rules. I think once we've gone through those we'll be well-positioned to review our messaging around "error" types and maybe iterate further on how they're explained to users. But that's a battle for another day.

tobySolutions · 2024-06-05T22:22:01Z

This is wonderful, thanks @tobySolutions!

We've got a bunch of issues filed to apply similar improvements to other no-unsafe-* rules. I think once we've gone through those we'll be well-positioned to review our messaging around "error" types and maybe iterate further on how they're explained to users. But that's a battle for another day.

Thank you so much for being super awesome Josh!!! This was such an amazing experience. I look forward to more contributions

kirkwaiblinger · 2024-07-16T20:46:01Z

We'll also need a no-duplicate-type-constitutents version of this I think, that doesn't just display the name differently, but also impacts the fixer logic (see also #9344 (comment))

fix: error assignment type issue

880eb39

tobySolutions added 3 commits January 26, 2024 15:42

refactor: error assignment type

0d14cc4

refactor: error assignment type

1cecfef

refactor: error assignment type

af01290

JoshuaKGoldberg requested changes Jan 29, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jan 29, 2024

chore: resolve comments

61457cb

JoshuaKGoldberg added the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Jun 2, 2024

tobySolutions added 3 commits June 2, 2024 20:14

fix: error type assignment tests

4764ce3

Merge branch 'main' of https://github.com/tobySolutions/typescript-es…

53ed246

…lint into fix/error-type-assignment

fix: error type assignment tests

e79ae86

JoshuaKGoldberg marked this pull request as ready for review June 2, 2024 19:32

JoshuaKGoldberg removed awaiting response Issues waiting for a reply from the OP or another party stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labels Jun 2, 2024

JoshuaKGoldberg self-requested a review June 2, 2024 19:32

JoshuaKGoldberg reviewed Jun 2, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

chore: change yarn lock

207d905

JoshuaKGoldberg requested changes Jun 2, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 2, 2024

JoshuaKGoldberg changed the title ~~fix: error assignment type issue~~ fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types Jun 2, 2024

tobySolutions added 2 commits June 2, 2024 21:02

fix: errot type assignments tests

4b14cd0

chore: remove unnecessary error type check function

da001c9

JoshuaKGoldberg reviewed Jun 2, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts Outdated Show resolved Hide resolved

tobySolutions added 2 commits June 2, 2024 21:18

refactor: rename every error ocurrence to error typed

809c291

refactor: rename every error ocurrence to error typed

602f6d9

tobySolutions added 3 commits June 2, 2024 22:01

refactor: rename every error ocurrence to error typed

ccb4d43

fix CI issues

7ef8aef

fix CI issues

48e03a0

JoshuaKGoldberg previously approved these changes Jun 3, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Jun 3, 2024

This was referenced Jun 3, 2024

Bug: [no-unsafe-assignment] Differentiate a types-error any from a "true" any #8231

Closed

Bug: [no-redundant-type-constituents] Differentiate a types-error any from a "true" any #9214

Closed

refactor: change create data from types function and add test data fo…

7ef85ee

…r test cases

tobySolutions dismissed JoshuaKGoldberg’s stale review via 7ef85ee June 3, 2024 02:42

tobySolutions requested a review from JoshuaKGoldberg June 3, 2024 02:43

refactor: remove unnecessary else

b70a2ca

JoshuaKGoldberg approved these changes Jun 5, 2024

View reviewed changes

JoshuaKGoldberg merged commit 293fb24 into typescript-eslint:main Jun 5, 2024
59 of 60 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types #8304

fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types #8304

tobySolutions commented Jan 26, 2024

typescript-eslint bot commented Jan 26, 2024

netlify bot commented Jan 26, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

nx-cloud bot commented Mar 25, 2024 •

edited

Loading

JoshuaKGoldberg commented May 26, 2024

tobySolutions commented May 26, 2024

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

tobySolutions commented Jun 3, 2024

Josh-Cena commented Jun 3, 2024

JoshuaKGoldberg commented Jun 3, 2024

Josh-Cena commented Jun 3, 2024

JoshuaKGoldberg commented Jun 3, 2024

JoshuaKGoldberg left a comment

tobySolutions commented Jun 5, 2024

kirkwaiblinger commented Jul 16, 2024 •

edited

Loading

fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types #8304

fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types #8304

Conversation

tobySolutions commented Jan 26, 2024

PR Checklist

Overview

typescript-eslint bot commented Jan 26, 2024

netlify bot commented Jan 26, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

nx-cloud bot commented Mar 25, 2024 • edited Loading

☁️ Nx Cloud Report

JoshuaKGoldberg commented May 26, 2024

tobySolutions commented May 26, 2024

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

tobySolutions commented Jun 3, 2024

Josh-Cena commented Jun 3, 2024

JoshuaKGoldberg commented Jun 3, 2024

Josh-Cena commented Jun 3, 2024

JoshuaKGoldberg commented Jun 3, 2024

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

tobySolutions commented Jun 5, 2024

kirkwaiblinger commented Jul 16, 2024 • edited Loading

netlify bot commented Jan 26, 2024 •

edited

Loading

nx-cloud bot commented Mar 25, 2024 •

edited

Loading

kirkwaiblinger commented Jul 16, 2024 •

edited

Loading