Skip to content

chore(eslint-plugin): fix typos in schema definitions #8311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Jan 29, 2024

PR Checklist

  • [-] Addresses an existing open issue: fixes #000
  • [-] That issue was marked as accepting prs
  • Steps in Contributing were taken

Overview

This fixes typos in the schema definitions.

I've been extracting the schemas from typescript-eslint (using jsonschema-extractor), and submitting them upstream to SchemaStore to improve autocompletion of .eslintrc.(json|yml|yaml) files (at least until people switch to flat config). Typos run into build errors over there.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hyperupcall!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@hyperupcall hyperupcall changed the title chore: Fix typos in schema definitions chore(eslint-plugin): Fix typos in schema definitions Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4ef26a9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65b6f41afaa50c0008262d5f
😎 Deploy Preview https://deploy-preview-8311--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@hyperupcall hyperupcall changed the title chore(eslint-plugin): Fix typos in schema definitions chore(eslint-plugin): fix typos in schema definitions Jan 29, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spots 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9dca40e into typescript-eslint:main Jan 29, 2024
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants