fix(eslint-plugin): [no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before as keyword
#8326
Conversation
…es for assertions with extra tokens before `as` keyword
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8326 +/- ##
==========================================
+ Coverage 87.71% 87.73% +0.01%
==========================================
Files 397 397
Lines 13948 13953 +5
Branches 4054 4055 +1
==========================================
+ Hits 12235 12241 +6
Misses 1401 1401
+ Partials 312 311 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // < ( number ) > ( 3 + 5 ) | ||
| // ^---remove---^ |
There was a problem hiding this comment.
[Non-Actionable] Somehow my brain immediately parsed this as an emoticon smiley... amused.
< ( number ) >
^---remove---^
…es for assertions with extra tokens before `as` keyword (typescript-eslint#8326) * fix(eslint-plugin): [no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before `as` keyword * fix: provide fixes for angle bracket assertions when there're tokens inside
PR Checklist
askeyword #8325Overview
I think the test cases and comments are a nice overview :)