Skip to content

chore: move generate-configs to repo-tools #8329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

bradzacher
Copy link
Member

Overview

Splitting out of #7935 to reduce line count.

  • move the generate-configs script from eslint-plugin to repo-tools
  • name all repo-tools files as .mts cos it's the future

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Feb 1, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 698677f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bb192905a26f000897dc02
😎 Deploy Preview https://deploy-preview-8329--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squidward writing on the floor saying "FUTURE"

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d805516) 87.71% compared to head (698677f) 87.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8329      +/-   ##
==========================================
- Coverage   87.71%   87.70%   -0.02%     
==========================================
  Files         397      397              
  Lines       13948    13950       +2     
  Branches     4054     4055       +1     
==========================================
  Hits        12235    12235              
- Misses       1401     1403       +2     
  Partials      312      312              
Flag Coverage Δ
unittest 87.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...internal/src/rules/no-typescript-default-import.ts 88.23% <0.00%> (-11.77%) ⬇️

@bradzacher bradzacher merged commit 2507481 into main Feb 1, 2024
@bradzacher bradzacher deleted the move-generate-configs-to-repo-tools branch February 1, 2024 04:39
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants