fix(eslint-plugin): [consistent-type-imports] dont report on types used in export assignment expressions #8332
Conversation
…ed in export assignment expressions
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8332 +/- ##
==========================================
- Coverage 87.71% 87.70% -0.02%
==========================================
Files 397 397
Lines 13948 13950 +2
Branches 4054 4055 +1
==========================================
Hits 12235 12235
- Misses 1401 1403 +2
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Thanks for hopping on this so fast!
I believe here should be no change required to the rule here - just a fix to the scope analysis. The tests are correct to add though!
Given the export equals declaration accepts an expression - we don't want to drop down into the export visitor. We just need a special case for the one special case - the identifier case. All other cases can be handled as a normal expression would.
In the identifier case we can immediately create a dual-reference. We know it's just this case because both T[U] and T.U are semantic errors from TS if T is a type, or T.U is a type (any syntactically those are the two valid ways to "chain" off a type reference).
…ed in export assignment expressions (typescript-eslint#8332)
PR Checklist
export =assertion #8330Overview
I missed that in #8265 :
In cases like
export = {} as T, T was referenced asisTypeReference: trueandisValueReference: true. Now it's only referenced as a type