Skip to content

fix(eslint-plugin): [switch-exhaustiveness-check] suggest with qualified name #8337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Feb 1, 2024

PR Checklist

Overview

The default type format flag of checker.typeToString is ts.TypeFormatFlags.AllowUniqueESSymbolType | ts.TypeFormatFlags.UseAliasDefinedOutsideCurrentScope.
This pr add ts.TypeFormatFlags.UseFullyQualifiedType to the flag for fixing #7747.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e970ea7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bcbd267be3c90008e21dd5
😎 Deploy Preview https://deploy-preview-8337--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@yeonjuan yeonjuan changed the title fix(eslint-plugin): [switch-exhaustiveness-check] make suggest with qualified name fix(eslint-plugin): [switch-exhaustiveness-check] suggest with qualified name Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c253a8) 87.71% compared to head (e970ea7) 87.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8337   +/-   ##
=======================================
  Coverage   87.71%   87.72%           
=======================================
  Files         397      397           
  Lines       13963    13972    +9     
  Branches     4061     4065    +4     
=======================================
+ Hits        12248    12257    +9     
  Misses       1403     1403           
  Partials      312      312           
Flag Coverage Δ
unittest 87.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 98.75% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@yeonjuan yeonjuan marked this pull request as ready for review February 1, 2024 18:14
@yeonjuan yeonjuan marked this pull request as draft February 2, 2024 10:03
@yeonjuan yeonjuan closed this Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [switch-exhaustiveness-check] Enum cases are not properly qualified in fixer
1 participant