Skip to content

chore: enable unused-vars caughtErrors: all internally #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2024
Merged

chore: enable unused-vars caughtErrors: all internally #8369

merged 2 commits into from
Feb 22, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Enables the rule's option and fixes a couple of existing violations.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit db2a74f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d60c407e9e3f0008b42ad8
😎 Deploy Preview https://deploy-preview-8369--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit db2a74f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f36f682) 86.94% compared to head (db2a74f) 87.74%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8369      +/-   ##
==========================================
+ Coverage   86.94%   87.74%   +0.80%     
==========================================
  Files         252      398     +146     
  Lines       12251    13827    +1576     
  Branches     3861     4067     +206     
==========================================
+ Hits        10652    12133    +1481     
- Misses       1332     1397      +65     
- Partials      267      297      +30
Flag Coverage Δ
unittest 87.74% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 146 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 5, 2024
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Feb 5, 2024 •
edited
Loading

I'll wait to merge these changes until the flat config work lands.

Edit: ✔️

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 6, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg removed the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 813ad93 into typescript-eslint:main Feb 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-unused-vars-caught-errors-all branch February 22, 2024 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable no-unused vars caughtErrors: all internally
2 participants
@JoshuaKGoldberg @bradzacher