Skip to content

docs(eslint-plugin): mention alternatives in no-explicit-any #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

docs(eslint-plugin): mention alternatives in no-explicit-any #8370

merged 1 commit into from
Feb 5, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Mentions the preferred strategies: interface or type for known data shapes; unknown for unknown data shapes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a6ddc9a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bfc8a583a5b10008d5eaf3
😎 Deploy Preview https://deploy-preview-8370--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a6ddc9a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 4, 2024
Merged
3 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8de6ee2) 87.70% compared to head (a6ddc9a) 87.80%.
Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8370      +/-   ##
==========================================
+ Coverage   87.70%   87.80%   +0.09%     
==========================================
  Files         397      398       +1     
  Lines       13950    14052     +102     
  Branches     4055     4090      +35     
==========================================
+ Hits        12235    12338     +103     
  Misses       1403     1403              
+ Partials      312      311       -1
Flag Coverage Δ
unittest 87.80% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <100.00%> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 95.28% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 97.91% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.56% <100.00%> (+0.09%) ⬆️
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.56% <100.00%> (+1.45%) ⬆️
packages/eslint-plugin/src/rules/prefer-find.ts 100.00% <100.00%> (ø)
...-estree/src/parseSettings/getProjectConfigFiles.ts 100.00% <100.00%> (ø)
packages/utils/src/eslint-utils/nullThrows.ts 80.00% <ø> (ø)
packages/utils/src/ts-eslint/Linter.ts 50.00% <ø> (ø)

@JoshuaKGoldberg JoshuaKGoldberg merged commit f892a72 into typescript-eslint:main Feb 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-explicit-any-mention-alternatives branch February 5, 2024 00:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mention that unknown is better in no-explicit-any description
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena