feat(utils): revert removal of backwards-compat functions #8399
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8399 +/- ##
==========================================
- Coverage 87.78% 86.94% -0.84%
==========================================
Files 397 252 -145
Lines 13821 12251 -1570
Branches 4067 3861 -206
==========================================
- Hits 12133 10652 -1481
+ Misses 1391 1332 -59
+ Partials 297 267 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Overview
Removed these in #8377 - but on second thought removing them is not good right now.
Our goal for this next major is that users just bump our peer dependencies (typescript and eslint). If we remove these functions then 3rd party plugins might break - meaning a user has to upgrade our peer deps AND 3rd party plugins. This isn't what we want - we want a isolated and painless major!
Adding them back and marking as
@deprecatedso that things keep working for now. We'll remove them in our next major.