fix(eslint-plugin): [ban-ts-comment] more accurate handling of multiline comments #8416
Conversation
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const matchedPragma = execDirectiveRegEx( | ||
| singleLinePragmaRegEx, | ||
| `//${comment.value}`, | ||
| ); |
There was a problem hiding this comment.
Perhaps to be fully consistent with TypeScript's behavior, we should even check that this comment is in the begging of the file. Because // @ts-nocheck placed after some code is not a valid pragma. Sounds like a good followup, wdyt?
There was a problem hiding this comment.
Yeah I'd +1 filing that as an issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8416 +/- ##
==========================================
+ Coverage 87.21% 87.23% +0.01%
==========================================
Files 251 251
Lines 12305 12316 +11
Branches 3880 3881 +1
==========================================
+ Hits 10732 10744 +12
+ Misses 1303 1302 -1
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
🔥 Really nicely done!
This reminds me that microsoft/TypeScript#38370 is still waiting for a spec. Heh.
| const matchedPragma = execDirectiveRegEx( | ||
| singleLinePragmaRegEx, | ||
| `//${comment.value}`, | ||
| ); |
There was a problem hiding this comment.
Yeah I'd +1 filing that as an issue.
…ine comments (typescript-eslint#8416) * fix(eslint-plugin): [ban-ts-comment] more accurate handling of multiline comments * chore: revert suggesstion message --------- Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
PR Checklist
Overview