Skip to content

chore: update to nx 18 #8442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2024
Merged

chore: update to nx 18 #8442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
867b29b
chore: update to nx 18
JamesHenry Feb 12, 2024
3bfc888
chore: fix test target for repo-tools
JamesHenry Feb 12, 2024
78e5a4f
chore: fix tests
JamesHenry Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@
"@babel/types": "^7.23.3",
"@eslint/eslintrc": "^2.1.4",
"@eslint/js": "^8.56.0",
"@nx/eslint": "17.3.1",
"@nx/jest": "17.3.1",
"@nx/workspace": "17.3.1",
"@nx/eslint": "18.0.4",
"@nx/jest": "18.0.4",
"@nx/workspace": "18.0.4",
"@swc/core": "^1.4.0",
"@swc/jest": "^0.2.26",
"@types/babel__code-frame": "^7.0.3",
Expand Down Expand Up @@ -110,7 +110,7 @@
"markdownlint-cli": "^0.39.0",
"ncp": "^2.0.0",
"netlify": "^13.1.9",
"nx": "17.3.1",
"nx": "18.0.4",
"prettier": "3.2.5",
"pretty-format": "^29.6.2",
"raw-loader": "^4.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/repo-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"generate-lib": "tsx ./src/generate-lib.mts",
"lint": "npx nx lint",
"postinstall-script": "tsx ./src/postinstall.mts",
"test": "jest --coverage",
"test": "npx jest --coverage",
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/rule-schema-to-typescript-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"generate-sponsors": "tsx ./src/generate-sponsors.ts",
"lint": "npx nx lint",
"postinstall-script": "tsx ./src/postinstall.ts",
"test": "jest --coverage",
"test": "npx jest --coverage",
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/rule-tester/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"lint": "npx nx lint",
"pretest-eslint-base": "tsc -b tsconfig.build.json",
"test-eslint-base": "mocha --require source-map-support/register ./tests/eslint-base/eslint-base.test.js",
"test": "jest --coverage",
"test": "npx jest --coverage",
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"//": "NOTE - AJV is out-of-date, but it's intentionally synced with ESLint - https://github.com/eslint/eslint/blob/ad9dd6a933fd098a0d99c6a9aa059850535c23ee/package.json#L70",
Expand Down
15 changes: 8 additions & 7 deletions tools/release/release.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import { execaSync } from 'execa';
import {
releaseChangelog,
releasePublish,
releaseVersion,
} from 'nx/src/command-line/release';
import { releaseChangelog, releasePublish, releaseVersion } from 'nx/release';
import yargs from 'yargs';

const options = await yargs(process.argv.slice(2))
Expand Down Expand Up @@ -46,12 +42,16 @@ if (!options.dryRun) {
}

// This will create a release on GitHub
await releaseChangelog({
const changelogStatus = await releaseChangelog({
versionData: projectsVersionData,
version: workspaceVersion,
dryRun: options.dryRun,
verbose: options.verbose,
});
if (changelogStatus !== 0) {
console.error('🚨 Failed to generate changelog');
process.exit(changelogStatus);
}

// An explicit null value here means that no changes were detected across any package
// eslint-disable-next-line eqeqeq
Expand All @@ -60,8 +60,9 @@ if (workspaceVersion === null) {
'⏭️ No changes detected across any package, skipping publish step altogether',
);
} else {
await releasePublish({
const publishStatus = await releasePublish({
dryRun: options.dryRun,
verbose: options.verbose,
});
process.exit(publishStatus);
}
Loading