Skip to content

chore: enable import/consistent-type-specifier-style internally #8527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

chore: enable import/consistent-type-specifier-style internally #8527

merged 1 commit into from
Feb 21, 2024

Conversation

tarunrajput
Copy link
Contributor

PR Checklist

Overview

Enables import/consistent-type-specifier-style rule
Lint with yarn lint --fix command

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tarunrajput!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 241c1c9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d644cdec5c650008fffb8f
😎 Deploy Preview https://deploy-preview-8527--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 88 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 21, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 241c1c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b615fc2) 87.74% compared to head (241c1c9) 87.74%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8527   +/-   ##
=======================================
  Coverage   87.74%   87.74%           
=======================================
  Files         398      398           
  Lines       13827    13827           
  Branches     4067     4067           
=======================================
  Hits        12133    12133           
  Misses       1397     1397           
  Partials      297      297
Flag Coverage Δ
unittest 87.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 97.29% <100.00%> (ø)
packages/eslint-plugin/src/rules/max-params.ts 94.44% <100.00%> (ø)
...ckages/scope-manager/src/referencer/TypeVisitor.ts 98.98% <100.00%> (ø)
...escript-estree/src/useProgramFromProjectService.ts 15.78% <ø> (ø)

bradzacher
bradzacher approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! thanks heaps!
coin_linter

@bradzacher bradzacher changed the title chore: enable import/consistent-type-specifier-style internally chore: enable import/consistent-type-specifier-style internally Feb 21, 2024
@bradzacher bradzacher merged commit dafefd0 into typescript-eslint:main Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable import/consistent-type-specifier-style internally
2 participants
@tarunrajput @bradzacher