Skip to content

docs: fill out maintenance docs on PR review flow #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Fills out PR review flow docs.

I'm sure I missed some important things 😄. What did I miss?

Co-authored-by: @auvred

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg requested review from bradzacher, auvred and a team February 24, 2024 14:54
Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d2e6b15
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65e898aff81713000803f59e
😎 Deploy Preview https://deploy-preview-8549--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (5e7ec8f) to head (d2e6b15).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8549      +/-   ##
==========================================
- Coverage   87.84%   87.21%   -0.63%     
==========================================
  Files         397      251     -146     
  Lines       13844    12303    -1541     
  Branches     4073     3880     -193     
==========================================
- Hits        12161    10730    -1431     
+ Misses       1381     1303      -78     
+ Partials      302      270      -32     
Flag Coverage Δ
unittest 87.21% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 208 files with indirect coverage changes

Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Very cool!

I'll just leave a few minor comments

@JoshuaKGoldberg JoshuaKGoldberg requested a review from auvred March 5, 2024 15:58
auvred
auvred previously approved these changes Mar 6, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 14649d1 into typescript-eslint:main Mar 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the pr-review-docs branch March 18, 2024 12:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Fill out docs for PR review flow
3 participants