Skip to content

feat(eslint-plugin): export types of ts rule option #8570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

feat(eslint-plugin): export types of ts rule option #8570

wants to merge 5 commits into from

Conversation

linlinyang
Copy link

Support eslint flat config

Example:

import type { Linter } from 'eslint';
import type {ruleOptions} from '@typescript-eslint/eslint-plugin';

// And than define rules:
type TSRules = {
  [K in keyof ruleOptions]?: Linter.RuleEntry<ruleOptions[K]>;
};
const rules: TSRules = {
  'accessor-pairs': 'error',
  'array-type': ['error', {
     readonly: 'array'
   }]
};

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @linlinyang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 779ffa9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65de8885c2af050009c0439d
😎 Deploy Preview https://deploy-preview-8570--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 28, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 779ffa9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@linlinyang linlinyang changed the title feat: export types of ts rule option feat(Eslint-plugin): export types of ts rule option Feb 28, 2024
@linlinyang linlinyang changed the title feat(Eslint-plugin): export types of ts rule option feat(eslint-plugin): export types of ts rule option Feb 28, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (4bc6944) to head (779ffa9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8570      +/-   ##
==========================================
- Coverage   87.84%   87.11%   -0.73%     
==========================================
  Files         397      251     -146     
  Lines       13844    12270    -1574     
  Branches     4073     3869     -204     
==========================================
- Hits        12161    10689    -1472     
+ Misses       1381     1309      -72     
+ Partials      302      272      -30
Flag Coverage Δ
unittest 87.11% <ø> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 147 files with indirect coverage changes

@linlinyang linlinyang changed the title feat(eslint-plugin): export types of ts rule option feat(eslint-plugin): export types of ts rule option Feb 28, 2024
auvred
auvred requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying from #8564 (review)

as per our contributing guide we ask that you raise an issue to discuss the change before raising a PR. https://typescript-eslint.io/contributing/pull-requests

You have also provided no real context in our PR description.

Please file an issue to describe your intended usecase so we can discuss it and the correct course of action.

If you believe @typescript-eslint/eslint-plugin should export some new types/values, please consider filing a new issue. That way we can discuss the details in a designated place.

The docs https://typescript-eslint.io/contributing/pull-requests explicitly states:

Please do:

But you removed the pull request template and didn't link an issue with accepting prs label. I'm going to close this PR again.

And copying from #8565 (comment)

Please don't raise duplicate PRs

@auvred auvred closed this Feb 28, 2024
@auvred auvred added the please fill out the template we have the processes for good reasons 😔 label Feb 28, 2024
@bradzacher
Copy link
Member

@linlinyang this is your final warning.

We have provided you with our requirements and instructions to proceed and you have ignored it 3 times now.

If you raise a duplicate PR again I will take action.

@linlinyang linlinyang mentioned this pull request Feb 28, 2024
Open
3 tasks
@linlinyang
Copy link
Author

@bradzacher sorry, i'm poor in raising PR

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auvred auvred auvred requested changes

Assignees
No one assigned
Labels
please fill out the template we have the processes for good reasons 😔
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linlinyang @bradzacher @auvred