Skip to content

fix(typescript-estree): improve error messaging around project files #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 19, 2019
Merged

fix(typescript-estree): improve error messaging around project files #866

merged 6 commits into from
Aug 19, 2019

Conversation

bradzacher
Copy link
Member

Fixes #853

People were having some problems because we now throw errors if files aren't included in the tsconfig.

This PR:

  • Improves the error messages so that required steps to fix the issue are clearer
  • Ensures that allowJs/checkJs are forced on, so that users don't ever have to manually turn it on in their configs.
    • This helps the system to "just work" without any real downside.
  • Added tests to make sure the errors occur as expected.
  • Improved documentation for the parser to clarify the setup for mixed js/ts codebases.

@bradzacher bradzacher added bug Something isn't working documentation Documentation ("docs") that needs adding/updating labels Aug 15, 2019
@typescript-eslint

This comment has been minimized.

Sign in to view
@bradzacher bradzacher mentioned this pull request Aug 15, 2019
Closed
JamesHenry
JamesHenry approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

JamesHenry
JamesHenry requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, should have checked the statuses first, tests are failing!

@bradzacher bradzacher force-pushed the parser-error-messages branch from 08b5c9d to d15f7f1 Compare August 19, 2019 15:20
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #866 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #866      +/-   ##
=========================================
- Coverage   94.17%   94.1%   -0.07%     
=========================================
  Files         113     113              
  Lines        4891    4906      +15     
  Branches     1362    1366       +4     
=========================================
+ Hits         4606    4617      +11     
- Misses        163     165       +2     
- Partials      122     124       +2
Impacted Files Coverage Δ
packages/typescript-estree/src/tsconfig-parser.ts 88% <100%> (ø) ⬆️
packages/typescript-estree/src/convert.ts 98.96% <100%> (ø) ⬆️
packages/typescript-estree/src/parser.ts 94.24% <100%> (+0.69%) ⬆️
...-plugin/src/rules/no-unnecessary-type-assertion.ts 88.15% <0%> (-2.64%) ⬇️
packages/eslint-plugin/src/util/types.ts 79.48% <0%> (-2.57%) ⬇️

@bradzacher bradzacher merged commit 8f3b0a8 into master Aug 19, 2019
@bradzacher bradzacher deleted the parser-error-messages branch August 19, 2019 15:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry requested changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tsconfig includes not recognized (typescript-eslint@2.0.0)
2 participants
@bradzacher @JamesHenry