-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: mention strict configs' stricter default rule options #8719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention strict configs' stricter default rule options #8719
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
`const defaultOptionsRecommended: Options = ${defaults};`, | ||
'', | ||
'// These options are merged on top of the recommended defaults', | ||
`const defaultOptionsStrict: Options = ${JSON.stringify(recommended.strict)};`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have liked to apply the actual merging logic so folks can see what the true defaults are for strict. But that'll be a little more involved. In the interest of getting this done faster I'd rather just merge this PR ASAP. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for quick fix. I'd like to see the merged config. Tho on second hand, it’s nice to see easily what are the things that changed.
So maybe this needs more thought with time? But for now this looks good to me. 👍
PR Checklist
Overview
Mentions the differences in configs in two ways:
defaultOptions*
variables