Skip to content

chore: enable eslint-plugin-perfectionist #8726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

chore: enable eslint-plugin-perfectionist #8726

wants to merge 10 commits into from

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Mar 19, 2024 •
edited
Loading

PR Checklist

Overview

Add eslint-plugin-perfectionist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@abrahamguo abrahamguo marked this pull request as draft March 19, 2024 12:47
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b71e8c0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65fc2cf20142f00008a694c3
😎 Deploy Preview https://deploy-preview-8726--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b71e8c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (59bbf41) to head (25656f2).

❗ Current head 25656f2 differs from pull request most recent head b71e8c0. Consider uploading reports for the commit b71e8c0 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8726   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files         254      254           
  Lines       12489    12489           
  Branches     3919     3919           
=======================================
  Hits        10914    10914           
  Misses       1304     1304           
  Partials      271      271
Flag Coverage Δ
unittest 87.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 91.54% <ø> (ø)
...t-plugin/src/rules/no-confusing-void-expression.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 96.42% <ø> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 83.87% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 80.68% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.56% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-unused-vars.ts 98.71% <ø> (ø)
...es/eslint-plugin/src/rules/object-curly-spacing.ts 100.00% <ø> (ø)
...int-plugin/src/rules/prefer-literal-enum-member.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/unbound-method.ts 95.29% <100.00%> (ø)
... and 1 more

@JoshuaKGoldberg
Copy link
Member

OH! Wait @abrahamguo, I had assigned #8479 to myself. This is going to involve some tricky stuff in the repo and a .git-blame-ignore-revs file.

Thanks for sending the PR, but I'm going to take this one.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 21, 2024
Closed
2 tasks
@abrahamguo abrahamguo mentioned this pull request Mar 21, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable alphabetical (natural) sorting of fields
2 participants
@abrahamguo @JoshuaKGoldberg