docs: restrict-template-expressions - remove mention of numbers being allowed #8734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allowed In the `recommended` config, numbers are allowed, but so are several other types. In the `strict` config, numbers are not allowed. Either way, "string and number" might not be the right documentation for what's allowed.
|
Thanks for the PR, @llllvvuu! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Josh-Cena
approved these changes
Mar 24, 2024
c787fe4
into
typescript-eslint:main
61 of 62 checks passed
peanutenthusiast
pushed a commit
to peanutenthusiast/typescript-eslint
that referenced
this pull request
Mar 27, 2024
… allowed (typescript-eslint#8734) docs(restrict-template-expressions): remove mention of numbers being allowed In the `recommended` config, numbers are allowed, but so are several other types. In the `strict` config, numbers are not allowed. Either way, "string and number" might not be the right documentation for what's allowed.
yeonjuan
pushed a commit
to yeonjuan/typescript-eslint
that referenced
this pull request
Mar 31, 2024
… allowed (typescript-eslint#8734) docs(restrict-template-expressions): remove mention of numbers being allowed In the `recommended` config, numbers are allowed, but so are several other types. In the `strict` config, numbers are not allowed. Either way, "string and number" might not be the right documentation for what's allowed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
recommendedconfig, numbers are allowed, but so are several other types. In thestrictconfig, numbers are not allowed (#8364). Either way, "string and number" might not be the right documentation for what's allowed.PR Checklist
N/A - small docs edit
Overview
small docs edit