Skip to content

fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside #8740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside #8740

merged 1 commit into from
Mar 25, 2024

Conversation

marcalexiei
Copy link
Contributor

@marcalexiei marcalexiei commented Mar 21, 2024 •
edited
Loading

PR Checklist

Overview

no-unnecessary-type-assertion now avoids to remove const casting from template literals when they are containing expressions.

This scenario is handled inside isConstVariableDeclaration which has been renamed to isLiteralVariableDeclarationChangingTypeWithConst to better reflect its purpose.

Edit: missed appreciation note... sorry
😅

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @marcalexiei!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e29f5cf
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65fc8754f1e11200085205ea
😎 Deploy Preview https://deploy-preview-8740--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 21, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e29f5cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (59bbf41) to head (e29f5cf).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8740   +/-   ##
=======================================
  Coverage   87.38%   87.39%           
=======================================
  Files         254      254           
  Lines       12489    12492    +3     
  Branches     3919     3920    +1     
=======================================
+ Hits        10914    10917    +3     
  Misses       1304     1304           
  Partials      271      271
Flag Coverage Δ
unittest 87.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.10% <100.00%> (+0.13%) ⬆️

@marcalexiei
fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove cons…
e29f5cf 
…t casting on template literals with expressions inside
@marcalexiei marcalexiei force-pushed the feature/template-literals-const branch from 1ecaf50 to e29f5cf Compare March 21, 2024 19:15
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, tricky stuff - thanks!

And appreciated on the appreciation note. 😁

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2a62a40 into typescript-eslint:main Mar 25, 2024
61 checks passed
@marcalexiei marcalexiei deleted the feature/template-literals-const branch March 25, 2024 19:13
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull request Mar 27, 2024
@marcalexiei @peanutenthusiast
fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove cons…
c7f14a4 
…t casting on template literals with expressions inside (typescript-eslint#8740)
yeonjuan pushed a commit to yeonjuan/typescript-eslint that referenced this pull request Mar 31, 2024
@marcalexiei @yeonjuan
fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove cons…
6d07f42 
…t casting on template literals with expressions inside (typescript-eslint#8740)
This was referenced Apr 1, 2024
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marcalexiei @JoshuaKGoldberg