Skip to content

fix(eslint-plugin): no-unused-vars: mark declared statements as used #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2019
Merged

fix(eslint-plugin): no-unused-vars: mark declared statements as used #88

merged 1 commit into from
Jan 20, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 20, 2019

This PR adds logic to mark all declared Identifiers used for no-unused-vars

fixes: #61

@codecov
Copy link

codecov bot commented Jan 20, 2019 •
edited
Loading

Codecov Report

Merging #88 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #88      +/-   ##
=========================================
+ Coverage    94.8%   94.8%   +<.01%     
=========================================
  Files          48      48              
  Lines        2465    2466       +1     
  Branches      380     380              
=========================================
+ Hits         2337    2338       +1     
  Misses         77      77              
  Partials       51      51
Impacted Files Coverage Δ
packages/eslint-plugin/lib/rules/no-unused-vars.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd27c5...70ed685. Read the comment docs.

@armano2 armano2 added enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Jan 20, 2019
@JamesHenry JamesHenry merged commit 2df5e0c into typescript-eslint:master Jan 20, 2019
@armano2 armano2 deleted the no-unused-vars branch January 20, 2019 14:30
@armano2 armano2 mentioned this pull request Jan 21, 2019
Closed
@j-f1 j-f1 mentioned this pull request Jan 21, 2019
Merged
armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull request Jan 24, 2019
@timothykang @JamesHenry
Fix: Mark qualified name type annotations as used (typescript-eslint#88)
a4362e7
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typescript/no-unused-vars] errors inside declare namespace
2 participants
@armano2 @JamesHenry