Skip to content

fix(eslint-plugin): [explicit-function-return-type] fix checking wrong ancestor's return type #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 20, 2024
Merged

fix(eslint-plugin): [explicit-function-return-type] fix checking wrong ancestor's return type #8809

merged 5 commits into from
Apr 20, 2024

Conversation

yeonjuan
Copy link
Contributor

…g ancestor's return type

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 31, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 44d9f3f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/662392b80aee45000847ac89
😎 Deploy Preview https://deploy-preview-8809--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 31, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 44d9f3f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@yeonjuan yeonjuan marked this pull request as ready for review April 1, 2024 13:36
kirkwaiblinger
kirkwaiblinger previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Makes sense to me!

thumbs up from borat

packages/eslint-plugin/src/util/explicitReturnTypeUtils.ts
return true;
}
break;
return !!ancestor.typeAnnotation;

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 19, 2024
auvred
auvred approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🔥

@codecov Codecov
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (5f38325) to head (00b1e57).

❗ Current head 00b1e57 differs from pull request most recent head 44d9f3f. Consider uploading reports for the commit 44d9f3f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8809      +/-   ##
==========================================
- Coverage   88.05%   87.36%   -0.70%     
==========================================
  Files         407      255     -152     
  Lines       14106    12495    -1611     
  Branches     4128     3921     -207     
==========================================
- Hits        12421    10916    -1505     
+ Misses       1381     1304      -77     
+ Partials      304      275      -29
Flag Coverage Δ
unittest 87.36% <100.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 97.61% <100.00%> (-0.09%) ⬇️

... and 162 files with indirect coverage changes

@auvred auvred mentioned this pull request Apr 20, 2024
Closed
3 tasks
@auvred auvred merged commit 9e0d9f5 into typescript-eslint:main Apr 20, 2024
57 of 58 checks passed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 21, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@auvred auvred auvred approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
3 participants
@yeonjuan @kirkwaiblinger @auvred