Skip to content

fix(typescript-estree): enable dot globs for project by default #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix(typescript-estree): enable dot globs for project by default #8818

merged 1 commit into from
Apr 19, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 1, 2024 •
edited
Loading

BREAKING CHANGE: Changes the default glob settings for projects.

PR Checklist

Overview

Enables dot: true.

Not sure if this should be a breaking change 🤔 but just to be safe, sending at the v8 branch.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the project-glob-dot-true branch from aaea9ea to ad2f2e8 Compare April 1, 2024 21:04
@JoshuaKGoldberg JoshuaKGoldberg changed the title Project glob dot true fix(typescript-estree): enable dot globs for project by default Apr 1, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 1, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ad2f2e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 2, 2024 12:32
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6e2e7d1 into typescript-eslint:v8 Apr 19, 2024
62 of 63 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the project-glob-dot-true branch April 19, 2024 15:21
JoshuaKGoldberg added a commit that referenced this pull request Apr 22, 2024
@JoshuaKGoldberg
fix(typescript-estree): enable dot globs for project by default (#8818)
2d835ee
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 22, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @kirkwaiblinger