Skip to content

feat(eslint-plugin): deprecate no-loss-of-precision extension rule #8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2024
Merged

feat(eslint-plugin): deprecate no-loss-of-precision extension rule #8832

merged 3 commits into from
Apr 22, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 4, 2024 •
edited
Loading

BREAKING CHANGE: Removes the rule from recommended-type-checked.

PR Checklist

Overview

Deprecates the rule and removes it from recommended.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0bb64bc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (716b783) to head (f029bda).
Report is 27 commits behind head on v8.

❗ Current head f029bda differs from pull request most recent head 0bb64bc. Consider uploading reports for the commit 0bb64bc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##               v8    #8832      +/-   ##
==========================================
- Coverage   88.02%   87.37%   -0.65%     
==========================================
  Files         405      255     -150     
  Lines       14089    12511    -1578     
  Branches     4125     3927     -198     
==========================================
- Hits        12402    10932    -1470     
+ Misses       1382     1304      -78     
+ Partials      305      275      -30
Flag Coverage Δ
unittest 87.37% <ø> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 100.00% <ø> (ø)

... and 150 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 4, 2024
kirkwaiblinger
kirkwaiblinger approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cast it into the fire!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5eba5ef into typescript-eslint:v8 Apr 22, 2024
53 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the deprecate-no-loss-of-precision branch April 22, 2024 17:55
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 22, 2024
Closed
JoshuaKGoldberg added a commit that referenced this pull request Apr 22, 2024
@JoshuaKGoldberg
feat(eslint-plugin): deprecate no-loss-of-precision extension rule (#…
61c2ee7 
…8832)

* feat(eslint-plugin): deprecate no-loss-of-precision extension rule

* baseRule.create, nice Kirk
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @kirkwaiblinger