Skip to content

feat(eslint-plugin): [prefer-nullish-coalescing] change ignoreConditionalTests default to true #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat(eslint-plugin): [prefer-nullish-coalescing] change ignoreConditionalTests default to true #8872

merged 1 commit into from
Apr 22, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 7, 2024 •
edited
Loading

BREAKING CHANGE:
Changes the default value of a rule's option.

PR Checklist

Overview

Straightforward change of the default value from false to true.

I'd considered renaming the option to checkConditionalTests so we could avoid having a truthy default... but figured that was a bit more user effort than folks are likely to want. I'd be happy to make that change if requested though.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 7, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c344d37
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66129ba1dd2b26000814361d
😎 Deploy Preview https://deploy-preview-8872--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c344d37. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 7, 2024 13:22
kirkwaiblinger
kirkwaiblinger approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Yay!

Regarding the description, I don't see a reason to change the name of the option.... People that have already specified the option manually will get to keep their configuration, rather than being punished with a broken lint run just because we changed our minds about a default. And people who have not specified it will be impacted identically independently of whether the name is changed.

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v8 April 21, 2024 12:39
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit c0c91e0 into typescript-eslint:v8 Apr 22, 2024
64 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-nullish-coalescing-ignore-conditional-tests-true branch April 22, 2024 17:55
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 22, 2024
Closed
2 tasks
JoshuaKGoldberg added a commit that referenced this pull request Apr 22, 2024
@JoshuaKGoldberg
feat(eslint-plugin): [prefer-nullish-coalescing] change ignoreConditi…
151cae2 
…onalTests default to true (#8872)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Configs: [prefer-nullish-coalescing] change default for ignoreConditionalTests to true
2 participants
@JoshuaKGoldberg @kirkwaiblinger