Skip to content

fix(eslint-plugin): [no-for-in-array] refine report location #8874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix(eslint-plugin): [no-for-in-array] refine report location #8874

merged 4 commits into from
Apr 22, 2024

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

just reduces the amount of squigglies

// before
for (const i in array) { console.log(array[i]); }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// after
for (const i in array) { console.log(array[i]); }
^^^^^^^^^^^^^^^^^^^^^^

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 7, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4de9b2a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66157b7494d6aa0008845afa
😎 Deploy Preview https://deploy-preview-8874--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4de9b2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger kirkwaiblinger force-pushed the for-in-array-report-loc branch from 5d13494 to 581e8cc Compare April 7, 2024 16:23
@kirkwaiblinger kirkwaiblinger force-pushed the for-in-array-report-loc branch from 581e8cc to 0e407fe Compare April 7, 2024 16:28
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review April 7, 2024 16:40
@yeonjuan yeonjuan mentioned this pull request Apr 8, 2024
Closed
9 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a tricky set of changes 😄 nice!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 9, 2024
@kirkwaiblinger kirkwaiblinger mentioned this pull request Apr 19, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg merged commit fdeba42 into typescript-eslint:main Apr 22, 2024
57 checks passed
@kirkwaiblinger kirkwaiblinger deleted the for-in-array-report-loc branch April 22, 2024 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkwaiblinger @JoshuaKGoldberg