Skip to content

fix(eslint-plugin): [prefer-readonly] refine report locations #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix(eslint-plugin): [prefer-readonly] refine report locations #8894

merged 4 commits into from
Jun 17, 2024

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Apr 10, 2024 •
edited
Loading

Blocked by #8869 since they'll use a shared utility

PR Checklist

Overview

class Clazz {
  // before
  private shouldBeReadonly = () => { /* ... */ };
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  // after
  private shouldBeReadonly = () => { /* ... */ };
  ~~~~~~~~~~~~~~~~~~~~~~~~
}

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 10, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9f3e403
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665fd6d0e26f1c0008492af7
😎 Deploy Preview https://deploy-preview-8894--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

kirkwaiblinger
kirkwaiblinger commented Apr 10, 2024
View reviewed changes
packages/eslint-plugin/src/rules/prefer-readonly.ts Outdated
* out in front of the key, and the key itself, but not anything afterwards,
* i.e. parens, type annotations, method bodies, or `?`.
*/
function getReportLoc(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract and reuse utilities from #8869

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 10, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9f3e403. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger kirkwaiblinger changed the title [prefer-readonly] Refine report locations fix(eslint-plugin): [prefer-readonly] Refine report locations Apr 10, 2024
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [prefer-readonly] Refine report locations fix(eslint-plugin): [prefer-readonly] refine report locations Apr 10, 2024
@yeonjuan yeonjuan mentioned this pull request Apr 10, 2024
Closed
9 tasks
@kirkwaiblinger kirkwaiblinger force-pushed the prefer-readonly-report-loc branch from fa24b6b to b5cad08 Compare April 10, 2024 07:31
@kirkwaiblinger kirkwaiblinger added blocked by another PR PRs which are ready to go but waiting on another PR enhancement New feature or request labels May 4, 2024
@kirkwaiblinger kirkwaiblinger removed the blocked by another PR PRs which are ready to go but waiting on another PR label May 29, 2024
@kirkwaiblinger
Copy link
Member Author

kirkwaiblinger commented May 30, 2024 •
edited
Loading

#8869 has been merged now, so I'll work on this soon to open it up for review

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in theory, nice @kirkwaiblinger! Is this ready for merge from main now that #8869 is merged?

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 2, 2024
@kirkwaiblinger
Copy link
Member Author

@JoshuaKGoldberg Not quite yet. I have a branch on my machine which does that and incorporates #8869. Just need to clean it up slightly before pushing and undrafting.

@kirkwaiblinger kirkwaiblinger force-pushed the prefer-readonly-report-loc branch from b5cad08 to c963914 Compare June 5, 2024 02:04
kirkwaiblinger
kirkwaiblinger commented Jun 5, 2024
View reviewed changes
packages/eslint-plugin/src/rules/explicit-member-accessibility.ts
* out in front of the key, and the key itself, but not anything afterwards,
* i.e. parens, type annotations, method bodies, or `?`.
*/
function getMissingAccessibilityReportLoc(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions are just moved to their own file so they can be shared

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 5, 2024
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review June 5, 2024 02:06
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 super!

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 50ed604 into typescript-eslint:main Jun 17, 2024
63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
@kirkwaiblinger kirkwaiblinger deleted the prefer-readonly-report-loc branch July 20, 2024 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Improve lint error report location
2 participants
@kirkwaiblinger @JoshuaKGoldberg