Skip to content

fix(eslint-plugin): [no-useless-template-literals] rename to no-useless-template-expression (ALTERNATE VERSION, copy-pasted) #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Copy rule over, deprecate existing rule.

This is an alternate version of #8821 in which the rule is copy/pasted rather than brought to common code, see #8821 (comment).

If this PR is chosen to supersede the other, any unaddressed feedback there must be addressed here before merging.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3c4ab99
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/661c455276e849000844b576
😎 Deploy Preview https://deploy-preview-8919--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
@kirkwaiblinger kirkwaiblinger deleted the rename-no-useless-template-literals-copypasta branch June 21, 2024 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Clarify purpose of no-useless-template-literal (or rename?)
1 participant