Skip to content

feat(eslint-plugin): [explicit-member-accessibility] add support of "ignoredMethodNames" #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 12, 2019
Merged

feat(eslint-plugin): [explicit-member-accessibility] add support of "ignoredMethodNames" #895

merged 10 commits into from
Sep 12, 2019

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Aug 22, 2019

Fixes #482

I added exceptMethods option for ignoring the rule when it is specified.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Aug 22, 2019
@lonyele lonyele force-pushed the feature/add-except-methods-option branch from f61bb4b to 874382c Compare September 6, 2019 09:54
bradzacher
bradzacher requested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic itself LGTM!

A few comments, as well as this request:

I know the initial request was for a duplicate of the class-methods-use-this rule's exceptMethods option, but I think I'd rather use a clearer name for the option.
I think ignoredMethodNames is much clearer about the intended usage.

@bradzacher bradzacher changed the title feat(esling-plugin): [explicit-member-accessibility] add support of "exceptMethods" feat(eslint-plugin): [explicit-member-accessibility] add support of "exceptMethods" Sep 10, 2019
@bradzacher bradzacher changed the title feat(eslint-plugin): [explicit-member-accessibility] add support of "exceptMethods" feat(eslint-plugin): [explicit-member-accessibility] add support of "ignoredMethodNames" Sep 10, 2019
bradzacher
bradzacher approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks for doing this

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 10, 2019
@lonyele
Copy link
Contributor Author

lonyele commented Sep 10, 2019

Just a side note, don't hesitate to say anything about the implementations. As long as it's something doable for me I'll definitely apply the feedbacks.

JamesHenry
JamesHenry approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JamesHenry JamesHenry removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #895 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   94.13%   94.13%   +<.01%     
==========================================
  Files         115      115              
  Lines        5011     5012       +1     
  Branches     1399     1400       +1     
==========================================
+ Hits         4717     4718       +1     
  Misses        166      166              
  Partials      128      128
Impacted Files Coverage Δ
...-plugin/src/rules/explicit-member-accessibility.ts 90.9% <100%> (+0.16%) ⬆️

@JamesHenry JamesHenry merged commit 46ee4c9 into typescript-eslint:master Sep 12, 2019
@lonyele lonyele deleted the feature/add-except-methods-option branch September 23, 2019 12:53
@mightyiam mightyiam mentioned this pull request Oct 3, 2019
Closed
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[explicit-member-accessibility] Add support of "exceptMethods"
3 participants
@lonyele @JamesHenry @bradzacher