Skip to content

feat(utils): swap LegacyESLint out for FlatESLint as ESLint export #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2024
Merged

feat(utils): swap LegacyESLint out for FlatESLint as ESLint export #8972

merged 3 commits into from
Apr 26, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 22, 2024 •
edited
Loading

BREAKING:
Changes the names of exports.

PR Checklist

Overview

Applies just a quick export name change so importing ESLint gives you FlatESLint, not LegacyESLint.

Also updates the TODO comment to reflect keeping the legacy class around.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg added the breaking change This change will require a new major version to be released label Apr 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 22, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 22, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a0d223f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

@JoshuaKGoldberg JoshuaKGoldberg merged commit e21b26e into typescript-eslint:v8 Apr 26, 2024
54 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the utils-swap-flateslint-legacyeslint branch April 26, 2024 13:55
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 26, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher