Skip to content

feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService #9084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 24, 2024
Merged

feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService #9084

merged 12 commits into from
May 24, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 13, 2024 •
edited
Loading

PR Checklist

Overview

Updates the naming and JSDoc-style comments around:

  • EXPERIMENTAL_useProjectService: simplifying it to just projectService
  • allowDefaultProjectForFiles: simplifying it to allowDefaultProject
  • TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: updates it to TYPESCRIPT_ESLINT_PROJECT_SERVICE

This is in parallel to #8031, which will need to be updated after this.

Also filed a separate #9085 to update the rest of our docs. I think that'll end up needing more discussion, so I'd like to get this in sooner & first.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg modified the milestones: v8, 8.0.0 May 13, 2024
@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit af60be8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6650599367809400087dd18b
😎 Deploy Preview https://deploy-preview-9084--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af60be8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 13, 2024
Closed
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg requested review from bradzacher and a team May 13, 2024 00:46
auvred
auvred requested changes May 13, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projectService looks much better than EXPERIMENTAL_useProjectService 😎

@auvred auvred added the awaiting response Issues waiting for a reply from the OP or another party label May 13, 2024
JoshuaKGoldberg and others added 3 commits May 13, 2024 08:00
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 13, 2024 15:02
@JoshuaKGoldberg JoshuaKGoldberg requested a review from auvred May 13, 2024 15:02
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label May 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 13, 2024
Merged
3 tasks
@kirkwaiblinger @Josh-Cena
docs: [no-floating-promises] fix capitalization typo (typescript-esli…
8d92ba8 
…nt#9118)

capialization typo

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@ehoogeveen-medweb ehoogeveen-medweb mentioned this pull request May 19, 2024
Closed
typescript-eslint bot and others added 2 commits May 20, 2024 17:17
@typescript-eslint
chore(release): publish 7.10.0
c18226e
@Connormiha
chore(eslint-plugin): replaced map/reduce with flatMap in normalizedO…
b5ce43b 
…ptions in parse (typescript-eslint#9122)

fix(naming-convention-utils): optimized normalizedOptions in parse
bradzacher
bradzacher approved these changes May 24, 2024
View reviewed changes
auvred
auvred approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the typecheck CI job failed, but otherwise LGTM! 👍

https://cloud.nx.app/runs/MNTVtFbVly

@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (87a0a48) to head (61a2c83).

❗ Current head 61a2c83 differs from pull request most recent head af60be8

Please upload reports for the commit af60be8 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v8    #9084      +/-   ##
==========================================
- Coverage   87.46%   87.46%   -0.01%     
==========================================
  Files         387      387              
  Lines       13117    13116       -1     
  Branches     3795     3795              
==========================================
- Hits        11473    11472       -1     
  Misses       1354     1354              
  Partials      290      290
Flag Coverage Δ
unittest 87.46% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-estree/src/create-program/createProjectService.ts 76.92% <ø> (ø)
...eate-program/validateDefaultProjectForFilesGlob.ts 100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 80.28% <100.00%> (ø)
...escript-estree/src/useProgramFromProjectService.ts 94.28% <ø> (-0.16%) ⬇️

@JoshuaKGoldberg JoshuaKGoldberg merged commit b9796c1 into typescript-eslint:v8 May 24, 2024
60 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the project-service-finalize-naming branch May 24, 2024 10:38
karlhorky added a commit to upleveled/preflight that referenced this pull request May 25, 2024
@karlhorky
Switch to useProjectService
4736914 
typescript-eslint/typescript-eslint#9084
@auvred auvred mentioned this pull request May 30, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@auvred auvred auvred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshuaKGoldberg @bradzacher @auvred @kirkwaiblinger @Connormiha