Skip to content

feat(rule-tester): stricter rule test validations #9086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 4, 2024
Merged

feat(rule-tester): stricter rule test validations #9086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f68e180
feat(rule-tester): Stricter rule test validations
Vinccool96 May 10, 2024
e5db11f
Linted eslint-base.test.js
Vinccool96 May 13, 2024
184814f
Fixed typing problems
Vinccool96 May 13, 2024
8342516
Forgotten lint
Vinccool96 May 13, 2024
7d3f0e7
Put back wrongly removed lines
Vinccool96 May 13, 2024
0e0a68b
Implemented missing suggestions
Vinccool96 May 13, 2024
8c3f96c
Implemented all missing suggestions
Vinccool96 May 13, 2024
bac7183
Sent expectedDesc back inside the if (hasOwnProperty(expectedSuggesti…
Vinccool96 May 13, 2024
2315437
Fixed unsubstitutedPlaceholders placement
Vinccool96 May 30, 2024
09bfd38
Fixed errors
Vinccool96 Jun 3, 2024
67b1a11
Removed unused import
Vinccool96 Jun 3, 2024
0c6fc1f
Fixed tests
Vinccool96 Jun 25, 2024
f6c0a91
Fixed tests
Vinccool96 Jun 25, 2024
4eebf7d
Fixed tests order
Vinccool96 Jun 27, 2024
0e08395
Added back in forgotten condition
Vinccool96 Jun 27, 2024
5f0bedc
Merge branch 'main' into feat/stricter-rule-test-validations
auvred Jun 27, 2024
9c956d1
Merge branch 'refs/heads/main' into feat/stricter-rule-test-validations
Vinccool96 Jun 29, 2024
cc5a70b
Applied suggestions
Vinccool96 Jun 29, 2024
7f201df
Merge branch 'refs/heads/main' into feat/stricter-rule-test-validations
Vinccool96 Jul 3, 2024
ea7f5f5
Fixed tests
Vinccool96 Jul 3, 2024
3bdc61e
Merge branch 'main' into feat/stricter-rule-test-validations
auvred Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/eslint-plugin/tests/rules/no-empty-object-type.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,16 @@ let value: unknown;
endColumn: 15,
endLine: 1,
messageId: 'noEmptyObject',
suggestions: [
{
messageId: 'replaceEmptyObjectType',
output: 'type Base = object | null;',
},
{
messageId: 'replaceEmptyObjectType',
output: 'type Base = unknown | null;',
},
],
},
],
options: [{ allowWithName: 'Base' }],
Expand All @@ -559,6 +569,16 @@ let value: unknown;
endColumn: 15,
endLine: 1,
messageId: 'noEmptyObject',
suggestions: [
{
messageId: 'replaceEmptyObjectType',
output: 'type Base = object;',
},
{
messageId: 'replaceEmptyObjectType',
output: 'type Base = unknown;',
},
],
},
],
options: [{ allowWithName: 'Mismatch' }],
Expand Down
Loading
Loading