Skip to content

chore(deps): dedupe dependencies and update test snapshots #9091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2024
Merged

chore(deps): dedupe dependencies and update test snapshots #9091

merged 4 commits into from
May 16, 2024

Conversation

rubiesonthesky
Copy link
Contributor

@rubiesonthesky rubiesonthesky commented May 13, 2024 •
edited
Loading

PR Checklist

Overview

Deduplicated dependencies, and updated snapshots.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rubiesonthesky!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 665dc48
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6645c0ad3a01320008defac9
😎 Deploy Preview https://deploy-preview-9091--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 665dc48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@rubiesonthesky rubiesonthesky marked this pull request as draft May 13, 2024 20:39
@rubiesonthesky rubiesonthesky marked this pull request as ready for review May 13, 2024 20:39
rubiesonthesky
rubiesonthesky commented May 13, 2024
View reviewed changes
package.json
@@ -138,6 +138,7 @@
"jest-util": "^29",
"pretty-format": "^29",
"react-split-pane@^0.1.92": "patch:react-split-pane@npm%3A0.1.92#./.yarn/patches/react-split-pane-npm-0.1.92-93dbf51dff.patch",
"tmp": "0.2.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned tmp version to 0.2.1 which is last working version. Newer have problem in Windows tests. There is probably something that can fixed there, but it will be easier to do it later.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 16, 2024
@rubiesonthesky
Copy link
Contributor Author

Let's hope that syncing with main does not break this now!

@JamesHenry JamesHenry merged commit 1a18eba into typescript-eslint:main May 16, 2024
60 of 61 checks passed
@rubiesonthesky rubiesonthesky deleted the run-yarn-dedupe branch May 21, 2024 17:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: renovate updates stuck?
3 participants
@rubiesonthesky @JoshuaKGoldberg @JamesHenry