Skip to content

feat(typescript-estree): remove EXPERIMENTAL_useSourceOfProjectReferenceRedirect #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2024
Merged

feat(typescript-estree): remove EXPERIMENTAL_useSourceOfProjectReferenceRedirect #9104

merged 6 commits into from
May 27, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

BREAKING CHANGE:
Removes a public option.

PR Checklist

Overview

Removes code around useSourceOfProjectReferenceRedirect altogether.

🔪

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from auvred May 16, 2024 00:08
@netlify Netlify
Copy link

netlify bot commented May 16, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5e48a1f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665331ccfd78e40008914ee5
😎 Deploy Preview https://deploy-preview-9104--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5e48a1f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg requested review from bradzacher and a team and removed request for auvred May 16, 2024 00:12
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the remove-use-source-of-project-reference-redirect branch from 01793a0 to 31f4cda Compare May 26, 2024 11:14
@auvred auvred added the breaking change This change will require a new major version to be released label May 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone May 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 92d4a26 into typescript-eslint:v8 May 27, 2024
60 checks passed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 27, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@auvred auvred auvred approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bradzacher @auvred