Skip to content

docs(eslint-plugin): [no-floating-promises] make void a more prominent suggestion #9117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

docs(eslint-plugin): [no-floating-promises] make void a more prominent suggestion #9117

merged 1 commit into from
May 28, 2024

Conversation

camsteffen
Copy link
Contributor

In my experience it is rather common to have legitimate cases to void a promise. The current state of the docs led me to believe that this is a "lesser preferred" option and I don't think that should be the case.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @camsteffen!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 18, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2c5e42d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6649119190bd0a00086ccb7f
😎 Deploy Preview https://deploy-preview-9117--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 18, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2c5e42d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@camsteffen
Copy link
Contributor Author

Slightly related: #8088

@camsteffen camsteffen force-pushed the no-danling-promises-likes-void branch from 45c06ae to 2c5e42d Compare May 18, 2024 20:37
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label May 28, 2024
@bradzacher bradzacher changed the title docs: [no-floating-promises] make void a more prominent suggestion docs(eslint-plugin): [no-floating-promises] make void a more prominent suggestion May 28, 2024
@bradzacher bradzacher merged commit c89306f into typescript-eslint:main May 28, 2024
59 of 60 checks passed
@camsteffen camsteffen deleted the no-danling-promises-likes-void branch May 28, 2024 09:22
@fpapado fpapado mentioned this pull request Jun 3, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camsteffen @bradzacher