Skip to content

chore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parse #9122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2024
Merged

chore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parse #9122

merged 1 commit into from
May 24, 2024

Conversation

Connormiha
Copy link
Contributor

I replaced map + reduce with concat with single flatMap.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Connormiha!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0ce70ba
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/664b128036cdfd00083da845
😎 Deploy Preview https://deploy-preview-9122--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0ce70ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@Connormiha Connormiha changed the title fix(naming-convention-utils): optimized normalizedOptions in parse fix(eslint-plugin): optimized normalizedOptions in parse May 20, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! ✨

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin): optimized normalizedOptions in parse chore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parse May 24, 2024
@JoshuaKGoldberg
Copy link
Member

Note that this is a chore, not a fix, as it's just an internal cleanliness thing. I would be shocked if there was ever any performance impact from a map/reduce -> flatMap in options parsing. 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit b5ce43b into typescript-eslint:main May 24, 2024
60 of 64 checks passed
JoshuaKGoldberg added a commit that referenced this pull request May 24, 2024
@JoshuaKGoldberg @auvred
@kirkwaiblinger @Josh-Cena @typescript-eslint @Connormiha
feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as …
b9796c1 
…projectService (#9084)

* feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService name as projectService

* lil typo

* Apply suggestions from code review

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

* Fix snapshot too

* A couple more experimental mentions

* docs: [no-floating-promises] fix capitalization typo (#9118)

capialization typo

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

* chore(release): publish 7.10.0

* chore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parse (#9122)

fix(naming-convention-utils): optimized normalizedOptions in parse

* Add missing Parser.mdx options

* Fix introduced type complaint

---------

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
Co-authored-by: Mikhail <bodrovmiha@yandex.ru>
@Josh-Cena
Copy link
Member

This should be refactor, not chore btw—a chore is something we do regularly like bumping deps or regenerating files

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Connormiha @JoshuaKGoldberg @Josh-Cena