Skip to content

fix: no-useless-template-expression -> no-unnecessary-template-expression #9174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2024
Merged

fix: no-useless-template-expression -> no-unnecessary-template-expression #9174

merged 5 commits into from
May 30, 2024

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented May 29, 2024 •
edited
Loading

PR Checklist

Overview

followup to an unresolved comment in #8821

a sanity check QA pass for completeness is to check the regex no.?useless.?template.?expression does not match anywhere in the repo anymore (including for filenames)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cf90a0d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6658decbc8dd86000823c2d2
😎 Deploy Preview https://deploy-preview-9174--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 29, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cf90a0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger kirkwaiblinger changed the title no-useless-template-expression -> no-unnecessary-template-expression fix: no-useless-template-expression -> no-unnecessary-template-expression May 29, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📛

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 29, 2024
@kirkwaiblinger kirkwaiblinger merged commit 26b95da into typescript-eslint:main May 30, 2024
60 checks passed
@kirkwaiblinger kirkwaiblinger deleted the rename-to-no-unnecessary-template-expression branch May 30, 2024 20:40
@fpapado fpapado mentioned this pull request Jun 3, 2024
Merged
3 tasks
@kirkwaiblinger kirkwaiblinger mentioned this pull request Jun 4, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees

@kirkwaiblinger kirkwaiblinger

Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirkwaiblinger @JoshuaKGoldberg @Josh-Cena