typescript-eslint · kirkwaiblinger · May 30, 2024 · May 29, 2024 · May 29, 2024 · May 30, 2024
diff --git a/.../rules/no-useless-template-expression.mdx → ...es/no-unnecessary-template-expression.mdx b/.../rules/no-useless-template-expression.mdx → ...es/no-unnecessary-template-expression.mdx
@@ -7,14 +7,14 @@ import TabItem from '@theme/TabItem';
 
 > 🛑 This file is source code, not the primary documentation location! 🛑
 >
-> See **https://typescript-eslint.io/rules/no-useless-template-expression** for documentation.
+> See **https://typescript-eslint.io/rules/no-unnecessary-template-expression** for documentation.
 
 This rule reports template literals that contain substitution expressions (also variously referred to as embedded expressions or string interpolations) that are unnecessary and can be simplified.
 
 :::info[Migration from `no-useless-template-literals`]
 
 This rule was formerly known as [`no-useless-template-literals`](./no-useless-template-literals.mdx).
-We encourage users to migrate to the new name, `no-useless-template-expression`, as the old name will be removed in a future major version of typescript-eslint.
+We encourage users to migrate to the new name, `no-unnecessary-template-expression`, as the old name will be removed in a future major version of typescript-eslint.
 
 The new name is a drop-in replacement with identical functionality.
 

diff --git a/packages/eslint-plugin/docs/rules/no-useless-template-literals.mdx b/packages/eslint-plugin/docs/rules/no-useless-template-literals.mdx
@@ -12,7 +12,7 @@ import TabItem from '@theme/TabItem';
 This rule reports template literals that contain substitution expressions (also variously referred to as embedded expressions or string interpolations) that are unnecessary and can be simplified.
 
 :::warning
-This rule is being renamed to [`no-useless-template-expression`](./no-useless-template-expression.mdx).
+This rule is being renamed to [`no-unnecessary-template-expression`](./no-unnecessary-template-expression.mdx).
 The current name, `no-useless-template-literals`, will be removed in a future major version of typescript-eslint.
 
 After the creation of this rule, it was realized that the name `no-useless-template-literals` could be misleading, seeing as this rule only targets template literals with substitution expressions.

diff --git a/packages/eslint-plugin/src/configs/all.ts b/packages/eslint-plugin/src/configs/all.ts
@@ -113,7 +113,7 @@ export = {
     'no-useless-constructor': 'off',
     '@typescript-eslint/no-useless-constructor': 'error',
     '@typescript-eslint/no-useless-empty-export': 'error',
-    '@typescript-eslint/no-useless-template-expression': 'error',
+    '@typescript-eslint/no-unnecessary-template-expression': 'error',
     '@typescript-eslint/no-var-requires': 'error',
     '@typescript-eslint/non-nullable-type-assertion-style': 'error',
     'no-throw-literal': 'off',

diff --git a/packages/eslint-plugin/src/configs/disable-type-checked.ts b/packages/eslint-plugin/src/configs/disable-type-checked.ts
@@ -39,7 +39,7 @@ export = {
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
     '@typescript-eslint/no-unsafe-unary-minus': 'off',
-    '@typescript-eslint/no-useless-template-expression': 'off',
+    '@typescript-eslint/no-unnecessary-template-expression': 'off',
     '@typescript-eslint/no-useless-template-literals': 'off',
     '@typescript-eslint/non-nullable-type-assertion-style': 'off',
     '@typescript-eslint/only-throw-error': 'off',

diff --git a/packages/eslint-plugin/src/configs/strict-type-checked-only.ts b/packages/eslint-plugin/src/configs/strict-type-checked-only.ts
@@ -33,7 +33,7 @@ export = {
     '@typescript-eslint/no-unsafe-enum-comparison': 'error',
     '@typescript-eslint/no-unsafe-member-access': 'error',
     '@typescript-eslint/no-unsafe-return': 'error',
-    '@typescript-eslint/no-useless-template-expression': 'error',
+    '@typescript-eslint/no-unnecessary-template-expression': 'error',
     'no-throw-literal': 'off',
     '@typescript-eslint/only-throw-error': 'error',
     '@typescript-eslint/prefer-includes': 'error',

diff --git a/packages/eslint-plugin/src/configs/strict-type-checked.ts b/packages/eslint-plugin/src/configs/strict-type-checked.ts
@@ -60,7 +60,7 @@ export = {
     '@typescript-eslint/no-unused-vars': 'error',
     'no-useless-constructor': 'off',
     '@typescript-eslint/no-useless-constructor': 'error',
-    '@typescript-eslint/no-useless-template-expression': 'error',
+    '@typescript-eslint/no-unnecessary-template-expression': 'error',
     '@typescript-eslint/no-var-requires': 'error',
     'no-throw-literal': 'off',
     '@typescript-eslint/only-throw-error': 'error',

diff --git a/packages/eslint-plugin/src/rules/index.ts b/packages/eslint-plugin/src/rules/index.ts
@@ -81,6 +81,7 @@ import noTypeAlias from './no-type-alias';
 import noUnnecessaryBooleanLiteralCompare from './no-unnecessary-boolean-literal-compare';
 import noUnnecessaryCondition from './no-unnecessary-condition';
 import noUnnecessaryQualifier from './no-unnecessary-qualifier';
+import noUnnecessaryTemplateExpression from './no-unnecessary-template-expression';
 import noUnnecessaryTypeArguments from './no-unnecessary-type-arguments';
 import noUnnecessaryTypeAssertion from './no-unnecessary-type-assertion';
 import noUnnecessaryTypeConstraint from './no-unnecessary-type-constraint';
@@ -97,7 +98,6 @@ import noUnusedVars from './no-unused-vars';
 import noUseBeforeDefine from './no-use-before-define';
 import noUselessConstructor from './no-useless-constructor';
 import noUselessEmptyExport from './no-useless-empty-export';
-import noUselessTemplateExpression from './no-useless-template-expression';
 import noUselessTemplateLiterals from './no-useless-template-literals';
 import noVarRequires from './no-var-requires';
 import nonNullableTypeAssertionStyle from './non-nullable-type-assertion-style';
@@ -227,6 +227,7 @@ export default {
   'no-unnecessary-boolean-literal-compare': noUnnecessaryBooleanLiteralCompare,
   'no-unnecessary-condition': noUnnecessaryCondition,
   'no-unnecessary-qualifier': noUnnecessaryQualifier,
+  'no-unnecessary-template-expression': noUnnecessaryTemplateExpression,
   'no-unnecessary-type-arguments': noUnnecessaryTypeArguments,
   'no-unnecessary-type-assertion': noUnnecessaryTypeAssertion,
   'no-unnecessary-type-constraint': noUnnecessaryTypeConstraint,
@@ -243,7 +244,6 @@ export default {
   'no-use-before-define': noUseBeforeDefine,
   'no-useless-constructor': noUselessConstructor,
   'no-useless-empty-export': noUselessEmptyExport,
-  'no-useless-template-expression': noUselessTemplateExpression,
   'no-useless-template-literals': noUselessTemplateLiterals,
   'no-var-requires': noVarRequires,
   'non-nullable-type-assertion-style': nonNullableTypeAssertionStyle,

diff --git a/...c/rules/no-useless-template-expression.ts → ...les/no-unnecessary-template-expression.ts b/...c/rules/no-useless-template-expression.ts → ...les/no-unnecessary-template-expression.ts
@@ -11,10 +11,10 @@ import {
   isUndefinedIdentifier,
 } from '../util';
 
-type MessageId = 'noUselessTemplateExpression';
+type MessageId = 'noUnnecessaryTemplateExpression';
 
 export default createRule<[], MessageId>({
-  name: 'no-useless-template-expression',
+  name: 'no-unnecessary-template-expression',
   meta: {
     fixable: 'code',
     type: 'suggestion',
@@ -24,7 +24,7 @@ export default createRule<[], MessageId>({
       requiresTypeChecking: true,
     },
     messages: {
-      noUselessTemplateExpression:
+      noUnnecessaryTemplateExpression:
         'Template literal expression is unnecessary and can be simplified.',
     },
     schema: [],
@@ -91,7 +91,7 @@ export default createRule<[], MessageId>({
         if (hasSingleStringVariable) {
           context.report({
             node: node.expressions[0],
-            messageId: 'noUselessTemplateExpression',
+            messageId: 'noUnnecessaryTemplateExpression',
             fix(fixer): TSESLint.RuleFix[] {
               const [prevQuasi, nextQuasi] = node.quasis;
 
@@ -125,7 +125,7 @@ export default createRule<[], MessageId>({
         fixableExpressions.forEach(expression => {
           context.report({
             node: expression,
-            messageId: 'noUselessTemplateExpression',
+            messageId: 'noUnnecessaryTemplateExpression',
             fix(fixer): TSESLint.RuleFix[] {
               const index = node.expressions.indexOf(expression);
               const prevQuasi = node.quasis[index];

diff --git a/packages/eslint-plugin/src/rules/no-useless-template-literals.ts b/packages/eslint-plugin/src/rules/no-useless-template-literals.ts
@@ -11,7 +11,7 @@ import {
   isUndefinedIdentifier,
 } from '../util';
 
-type MessageId = 'noUselessTemplateExpression';
+type MessageId = 'noUnnecessaryTemplateExpression';
 
 export default createRule<[], MessageId>({
   name: 'no-useless-template-literals',
@@ -23,12 +23,12 @@ export default createRule<[], MessageId>({
       requiresTypeChecking: true,
     },
     messages: {
-      noUselessTemplateExpression:
+      noUnnecessaryTemplateExpression:
         'Template literal expression is unnecessary and can be simplified.',
     },
     schema: [],
     deprecated: true,
-    replacedBy: ['@typescript-eslint/no-useless-template-expression'],
+    replacedBy: ['@typescript-eslint/no-unnecessary-template-expression'],
   },
   defaultOptions: [],
   create(context) {
@@ -92,7 +92,7 @@ export default createRule<[], MessageId>({
         if (hasSingleStringVariable) {
           context.report({
             node: node.expressions[0],
-            messageId: 'noUselessTemplateExpression',
+            messageId: 'noUnnecessaryTemplateExpression',
             fix(fixer): TSESLint.RuleFix[] {
               const [prevQuasi, nextQuasi] = node.quasis;
 
@@ -126,7 +126,7 @@ export default createRule<[], MessageId>({
         fixableExpressions.forEach(expression => {
           context.report({
             node: expression,
-            messageId: 'noUselessTemplateExpression',
+            messageId: 'noUnnecessaryTemplateExpression',
             fix(fixer): TSESLint.RuleFix[] {
               const index = node.expressions.indexOf(expression);
               const prevQuasi = node.quasis[index];

diff --git a/...shots/no-useless-template-expression.shot → ...s/no-unnecessary-template-expression.shot b/...shots/no-useless-template-expression.shot → ...s/no-unnecessary-template-expression.shot