Skip to content

fix(rule-tester): set configType to eslintrc in Linter options #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented May 30, 2024

This was a regression on v8 caused by a merge from main

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 541817f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665858f1d7636800086bf7bb

@JamesHenry
Copy link
Member Author

JamesHenry commented May 30, 2024

@JoshuaKGoldberg website build failures seem unrelated to this PR:

screenshot of build failure on netlify

@JamesHenry
Copy link
Member Author

Confirmed the website deploy is also failing on #9165

@JamesHenry JamesHenry merged commit e3eb1ad into v8 May 30, 2024
63 of 67 checks passed
@JamesHenry JamesHenry deleted the v8-rule-tester-config-type branch May 30, 2024 11:04
@JoshuaKGoldberg
Copy link
Member

👍 fixed in f279b6d, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants