feat(eslint-plugin): [no-floating-promises] add option 'allowForKnownSafePromises' #9186
Conversation
'allowForKnownSafePromises' option fixes: typescript-eslint#7008
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
🔥 🔥 🔥
So pumped to see this land! I like how it ended up being a mostly additive change. This is great. Nice job @arka1002 + @kirkwaiblinger!
Nothing blocking from me - I'm happy to see this merged asap.
packages/eslint-plugin/tests/rules/no-floating-promises.test.ts
Outdated
Show resolved
Hide resolved
04990d5
into
typescript-eslint:main
PR Checklist
Overview
This PR is a continuation of #8502, with a few finishing touches.
A big thank you to @arka1002, who is the primary author of this work! ❤️
Co-authored-by: @arka1002