Skip to content

docs: mention testing changes and keeping PRs up-to-date in PR docs #9246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 4, 2024

PR Checklist

Overview

Lumps the two issues in together since they both touch the same page.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 805db5f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665f5a2d2d29a4000827bb68
😎 Deploy Preview https://deploy-preview-9246--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from Josh-Cena June 4, 2024 16:00
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (a481002) to head (a1b78b4).
Report is 6 commits behind head on main.

Current head a1b78b4 differs from pull request most recent head 805db5f

Please upload reports for the commit 805db5f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9246      +/-   ##
==========================================
- Coverage   88.05%   87.42%   -0.64%     
==========================================
  Files         411      261     -150     
  Lines       14303    12724    -1579     
  Branches     4173     3975     -198     
==========================================
- Hits        12595    11124    -1471     
+ Misses       1397     1319      -78     
+ Partials      311      281      -30     
Flag Coverage Δ
unittest 87.42% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 150 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg requested a review from Josh-Cena June 4, 2024 18:17
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 4, 2024

- Including both `valid` and `invalid` code changes in most PRs that affect rule behavior
- Limiting to one error per `invalid` case

### Type Checking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. should this section move too? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - I see this page as the "here are the raw commands you'll use".

kirkwaiblinger

This comment was marked as off-topic.

@JoshuaKGoldberg JoshuaKGoldberg merged commit ae3cec5 into typescript-eslint:main Jun 5, 2024
62 of 63 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-testing-and-merging-in-prs branch June 5, 2024 13:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
3 participants