-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: mention testing changes and keeping PRs up-to-date in PR docs #9246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention testing changes and keeping PRs up-to-date in PR docs #9246
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9246 +/- ##
==========================================
- Coverage 88.05% 87.42% -0.64%
==========================================
Files 411 261 -150
Lines 14303 12724 -1579
Branches 4173 3975 -198
==========================================
- Hits 12595 11124 -1471
+ Misses 1397 1319 -78
+ Partials 311 281 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
||
- Including both `valid` and `invalid` code changes in most PRs that affect rule behavior | ||
- Limiting to one error per `invalid` case | ||
|
||
### Type Checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. should this section move too? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - I see this page as the "here are the raw commands you'll use".
ae3cec5
into
typescript-eslint:main
PR Checklist
main
#8610, fixes Docs: Move PR-specific testing advice from Contributing > Local Development to Pull Requests #9210Overview
Lumps the two issues in together since they both touch the same page.
💖