Skip to content

chore(website): align file names to RuleTester requirements #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore(website): align file names to RuleTester requirements #9271

merged 1 commit into from
Jun 5, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Creates and uses a helper in the website to always keep file names as file.ts or react.tsx.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c9fda51
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665f6f389c95b90008a8d2e1
😎 Deploy Preview https://deploy-preview-9271--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c9fda51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft June 4, 2024 19:42
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the website-file-names-align branch 2 times, most recently from 568ede8 to 6beecb9 Compare June 4, 2024 19:45
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the website-file-names-align branch from 6beecb9 to c9fda51 Compare June 4, 2024 19:47
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jun 4, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 4, 2024 20:21
@JoshuaKGoldberg JoshuaKGoldberg requested review from armano2 and a team June 4, 2024 20:21
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit d28bcb6 into typescript-eslint:main Jun 5, 2024
65 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the website-file-names-align branch June 5, 2024 13:12
@bradzacher bradzacher mentioned this pull request Jun 11, 2024
Closed
@bradzacher
Copy link
Member

It looks like this change broke the website.
#9323

JoshuaKGoldberg added a commit that referenced this pull request Jun 11, 2024
@JoshuaKGoldberg
Revert "chore(website): align file names to RuleTester requirements (#…
f9bce99 
…9271)"

This reverts commit d28bcb6.
This was referenced Jun 11, 2024
Merged
Open
JoshuaKGoldberg added a commit that referenced this pull request Jun 11, 2024
@JoshuaKGoldberg
Revert "chore(website): align file names to RuleTester requirements" (#…
33f723f 
…9327)

Revert "chore(website): align file names to RuleTester requirements (#9271)"

This reverts commit d28bcb6.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@armano2 armano2 Awaiting requested review from armano2

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground: Virtual file name discrepancy between playground (input.ts) and docs & rule tests (file.ts)
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena