Skip to content

fix(eslint-plugin): [no-unsafe-member-access] differentiate a types-error any from a true any #9291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2024
Merged

fix(eslint-plugin): [no-unsafe-member-access] differentiate a types-error any from a true any #9291

merged 7 commits into from
Jun 17, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Jun 6, 2024 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 6, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 72a1769
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/667004fac9aa7e000895a696
😎 Deploy Preview https://deploy-preview-9291--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72a1769. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean to me! Just one suggestion to align with previous changes in the area? ✨

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 8, 2024
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just did a deeper look-through and realized I'd missed the unsafeComputedMemberAccess point?

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jun 8, 2024
Merged
3 tasks
@y-hsgw y-hsgw requested a review from JoshuaKGoldberg June 9, 2024 01:21
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 9, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! ✨

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit bf48dc5 into typescript-eslint:main Jun 17, 2024
61 checks passed
@y-hsgw y-hsgw deleted the fix/no-unsafe-member-access branch June 17, 2024 13:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehoogeveen-medweb ehoogeveen-medweb ehoogeveen-medweb left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unsafe-member-access] Differentiate a types-error any from a "true" any
3 participants
@y-hsgw @JoshuaKGoldberg @ehoogeveen-medweb