Skip to content

fix(eslint-plugin): [no-unsafe-call] differentiate a types-error any from a true any #9304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2024
Merged

fix(eslint-plugin): [no-unsafe-call] differentiate a types-error any from a true any #9304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
777a513
fix(eslint-plugin): [no-unsafe-call] differentiate a types-error any …
Vinccool96 Jun 7, 2024
da5cb6e
Fixed docs tests
Vinccool96 Jun 7, 2024
8fdd8f2
Fixed error message and tests
Vinccool96 Jun 8, 2024
2c870ab
Fixed error message
Vinccool96 Jun 9, 2024
c1390ff
Fixed description and message
Vinccool96 Jun 17, 2024
d983b7d
Merge branch 'refs/heads/main' into fix/eslint-plugin/no-unsafe-call-…
Vinccool96 Jun 29, 2024
2735d4d
Applied suggestions
Vinccool96 Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/eslint-plugin/src/rules/no-unsafe-call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default createRule<[], MessageIds>({
requiresTypeChecking: true,
},
messages: {
unsafeCall: 'Unsafe call of an `any` typed value.',
unsafeCall: 'Unsafe call of an {{type}} typed value.',
unsafeCallThis: [
'Unsafe call of an `any` typed value. `this` is typed as `any`.',
'You can try to fix this by turning on the `noImplicitThis` compiler option, or adding a `this` parameter to the function.',
Expand Down Expand Up @@ -64,9 +64,15 @@ export default createRule<[], MessageIds>({
messageId = 'unsafeCallThis';
}
}

const isErrorType = tsutils.isIntrinsicErrorType(type);

context.report({
node: reportingNode,
messageId: messageId,
data: {
type: isErrorType ? '`error` type' : '`any`',
},
});
}
}
Expand Down
101 changes: 94 additions & 7 deletions packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,55 +51,125 @@ function foo(x: any) {
x();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 4,
data: {
type: '`any`',
},
},
],
},
{
code: `
function foo(x: any) {
x?.();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 4,
data: {
type: '`any`',
},
},
],
},
{
code: `
function foo(x: any) {
x.a.b.c.d.e.f.g();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 18,
data: {
type: '`any`',
},
},
],
},
{
code: `
function foo(x: any) {
x.a.b.c.d.e.f.g?.();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 18,
data: {
type: '`any`',
},
},
],
},
{
code: `
function foo(x: { a: any }) {
x.a();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 6,
data: {
type: '`any`',
},
},
],
},
{
code: `
function foo(x: { a: any }) {
x?.a();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 7,
data: {
type: '`any`',
},
},
],
},
{
code: `
function foo(x: { a: any }) {
x.a?.();
}
`,
errors: [{ messageId: 'unsafeCall' }],
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 3,
endColumn: 6,
data: {
type: '`any`',
},
},
],
},
{
code: `
Expand Down Expand Up @@ -163,5 +233,22 @@ const methods = {
},
],
},
{
code: `
let value: NotKnown;
value();
`,
errors: [
{
messageId: 'unsafeCall',
line: 3,
column: 1,
endColumn: 6,
data: {
type: '`error` type',
},
},
],
},
],
});
Loading