Skip to content

fix(types): allow ProjectServiceOptions for projectService #9318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 10, 2024

PR Checklist

Overview

Adds in the missing | ProjectServiceOptions to the types package's ParserOptions. That necessitates taking in the ProjectServiceOptions into the types package.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 12e13b1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6666f5e3d5f60600083ac945
😎 Deploy Preview https://deploy-preview-9318--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jun 10, 2024

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team June 10, 2024 12:51
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 10, 2024
@JoshuaKGoldberg
Copy link
Member Author

Merging this in after only a few hours of 1 approval so it gets released today. Normally I'd wait a little longer - someone please yell at me if they have anything they'd want to request changes on!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0f1b064 into typescript-eslint:v8 Jun 10, 2024
69 checks passed
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jun 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants