Skip to content

feat(eslint-plugin): [no-unused-vars] handle comma operator for assignments, treat for-of the same as for-in #9326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat(eslint-plugin): [no-unused-vars] handle comma operator for assignments, treat for-of the same as for-in #9326

merged 1 commit into from
Jun 25, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Syncs eslint/eslint#15868, eslint/eslint#14928 and eslint/eslint#14354 from upstream

NOTE: stacked on top of #9325 - retarget to v8 before merging

@bradzacher bradzacher added the enhancement New feature or request label Jun 11, 2024
@bradzacher bradzacher added this to the 8.0.0 milestone Jun 11, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 11, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a34bf24. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@bradzacher bradzacher force-pushed the no-unused-vars-ignoreClassWithStaticInitBlock branch from 5663753 to 06b25f0 Compare June 11, 2024 04:18
@bradzacher bradzacher force-pushed the no-unused-vars-v8-resync-upstream-tests branch from a371edb to 34b44cc Compare June 11, 2024 04:18
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.47%. Comparing base (332a271) to head (a34bf24).

Additional details and impacted files 
@@           Coverage Diff           @@
##               v8    #9326   +/-   ##
=======================================
  Coverage   87.46%   87.47%           
=======================================
  Files         394      394           
  Lines       13336    13345    +9     
  Branches     3859     3862    +3     
=======================================
+ Hits        11664    11673    +9     
  Misses       1366     1366           
  Partials      306      306
Flag Coverage Δ
unittest 87.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/eslint-plugin/src/util/collectUnusedVariables.ts 93.65% <100.00%> (+0.23%) ⬆️

@bradzacher bradzacher changed the title feat(eslint-plugin): handle comma operator for assignments, treat for-of the same as for-in feat(eslint-plugin): [no-unused-vars] handle comma operator for assignments, treat for-of the same as for-in Jun 11, 2024
@bradzacher bradzacher mentioned this pull request Jun 18, 2024
Closed
4 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 24, 2024
@bradzacher bradzacher force-pushed the no-unused-vars-ignoreClassWithStaticInitBlock branch from 06b25f0 to 7a8ca35 Compare June 25, 2024 05:11
Base automatically changed from no-unused-vars-ignoreClassWithStaticInitBlock to v8 June 25, 2024 07:28
@bradzacher bradzacher force-pushed the no-unused-vars-v8-resync-upstream-tests branch from 34b44cc to a34bf24 Compare June 25, 2024 07:29
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a34bf24
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/667a71dc79ae120008d5b93f
😎 Deploy Preview https://deploy-preview-9326--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher bradzacher merged commit ec20eaf into v8 Jun 25, 2024
64 checks passed
@bradzacher bradzacher deleted the no-unused-vars-v8-resync-upstream-tests branch June 25, 2024 09:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge enhancement New feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @JoshuaKGoldberg