Skip to content

feat(typescript-estree): exposes ProjectService logs through the plugin #9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2024
Merged

feat(typescript-estree): exposes ProjectService logs through the plugin #9337

merged 6 commits into from
Jun 17, 2024

Conversation

higherorderfunctor
Copy link
Contributor

@higherorderfunctor higherorderfunctor commented Jun 11, 2024 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Exposes the following logs populated by ProjectService.

typescript-eslint:typescript-estree:tsserver:err
typescript-eslint:typescript-estree:tsserver:info
typescript-eslint:typescript-estree:tsserver:perf
typescript-eslint:typescript-estree:tsserver:event

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @higherorderfunctor!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2651587
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/666b69c0b3782300081484a3
😎 Deploy Preview https://deploy-preview-9337--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@higherorderfunctor higherorderfunctor changed the base branch from main to v8 June 11, 2024 22:59
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 11, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2651587. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks lovely, thanks! Tests and all. I'm happy with it as-is but want to also ping @bradzacher and @jakebailey as FYIs as they've both worked on these areas / might have insights too. ✨

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jun 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 13, 2024 09:14
@higherorderfunctor higherorderfunctor mentioned this pull request Jun 13, 2024
Closed
4 tasks
@higherorderfunctor
Copy link
Contributor Author

higherorderfunctor commented Jun 13, 2024 •
edited
Loading

This should be good to go. Updated the docs. I did make one small change. I figured it would be better to send undefined to tsserver instead of a function in case it saves on needing to generate those events.

-    eventHandler: (e): void => {
-      logTsserverEvent(e);
-    },
+    eventHandler: logTsserverEvent.enabled
+      ? (e): void => {
+          logTsserverEvent(e);
+        }
+      : undefined,

@higherorderfunctor higherorderfunctor mentioned this pull request Jun 14, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg merged commit c170c3d into typescript-eslint:v8 Jun 17, 2024
61 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the feat/9321-expose-ts-project-service-logs branch June 17, 2024 12:53
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jun 17, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement(typescript-estree): expose ProjectService logs through plugin
3 participants
@higherorderfunctor @JoshuaKGoldberg @bradzacher