Skip to content

feat(eslint-plugin): add new rule: @typescript-eslint/deprecation #9346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

luca-script
Copy link

PR Checklist

Overview

Adds a new deprecation rule
This rule has been written fully from scratch (Starting from an empty file).

It works well in most cases (Outside of when either types aren't available, or JSX is used), and can catch usages that eslint-plugin-deprecation misses (Specifically shorthand object syntax)

JSX support hasn't been implemented yet as of the draft of this PR, but should be implemented before being merged

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @luca-script!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fe8fcdd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/666ab8e01871d10008d712df
😎 Deploy Preview https://deploy-preview-9346--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@luca-script luca-script changed the title feat(eslint-plugin): Add new rule: @typescript-eslint/deprecation feat(eslint-plugin): add new rule: @typescript-eslint/deprecation Jun 13, 2024
Copy link

nx-cloud bot commented Jun 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe8fcdd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JoshuaKGoldberg
Copy link
Member

@luca-script thanks for sending this in, but:

  • The issue isn't marked as accepting PRs, despite your checking it in the PR template
  • Per the issue, "I think a member of the typescript-eslint team should work on it."

Closing because I don't want to incur any extra work on your end that might not be taken in. Again, thank you, I appreciate the enthusiasm on your end!

@luca-script luca-script deleted the addDeprecation branch June 13, 2024 09:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants